From dcc992588214751fc5e29b036b8baf724dadbef9 Mon Sep 17 00:00:00 2001
From: GTBarkley <barkleygrant@gmail.com>
Date: Mon, 12 Jun 2023 04:02:16 +0000
Subject: [PATCH] wrote some characterizations of bounding krull

---
 comm_alg/grant.lean | 21 ++++++++++++++++++++-
 1 file changed, 20 insertions(+), 1 deletion(-)

diff --git a/comm_alg/grant.lean b/comm_alg/grant.lean
index 92b1716..8586fa3 100644
--- a/comm_alg/grant.lean
+++ b/comm_alg/grant.lean
@@ -28,6 +28,7 @@ def series_to_chain : StrictSeries s → s.subchain
 
 -- there should be a coercion from WithTop ℕ to WithBot (WithTop ℕ) but it doesn't seem to work
 -- it looks like this might be because someone changed the instance from CoeCT to Coe during the port
+-- actually it looks like we can coerce to WithBot (ℕ∞) fine
 lemma twoHeights : s ≠ ∅ → (some (Set.chainHeight s) : WithBot (WithTop ℕ)) = krullDim s := by
   intro hs
   unfold Set.chainHeight
@@ -38,5 +39,23 @@ lemma twoHeights : s ≠ ∅ → (some (Set.chainHeight s) : WithBot (WithTop 
   -- norm_cast
   sorry
 
+namespace Ideal
+noncomputable def krullDim (R : Type _) [CommRing R] := 
+  Set.chainHeight (Set.univ : Set (PrimeSpectrum R))
+
 def krullDimGE (R : Type _) [CommRing R] (n : ℕ) :=
-  ∃ c : List (PrimeSpectrum R), c.Chain' (· < ·) ∧ c.length = n + 1
\ No newline at end of file
+  ∃ c : List (PrimeSpectrum R), c.Chain' (· < ·) ∧ c.length = n + 1
+
+def krullDimLE (R : Type _) [CommRing R] (n : ℕ) :=
+  ∀ c : List (PrimeSpectrum R), c.Chain' (· < ·) → c.length ≤ n + 1
+
+end Ideal
+
+open Ideal
+
+lemma krullDim_le (R : Type _) [CommRing R] : krullDimLE R n ↔ Ideal.krullDim R ≤ n := sorry
+lemma krullDim_ge (R : Type _) [CommRing R] : krullDimGE R n ↔ Ideal.krullDim R ≥ n := sorry
+
+
+-- #check ((4 : ℕ∞) : WithBot (WithTop ℕ))
+#check ( (Set.chainHeight s) : WithBot (ℕ∞))
\ No newline at end of file